Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarks in Other Bookmarks folder is synced to the bookmark toolbar #8024

Closed
luixxiul opened this issue Apr 1, 2017 · 3 comments · Fixed by #9216
Closed

Bookmarks in Other Bookmarks folder is synced to the bookmark toolbar #8024

luixxiul opened this issue Apr 1, 2017 · 3 comments · Fixed by #9216
Assignees
@diracdeltas
Labels
bug feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 1, 2017 •
edited
Loading

Test plan

#9216 (comment)

Describe the issue you encountered: Bookmarks in Other Bookmarks folder is synced to the bookmark toolbar

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.14.1 RC1

  • Steps to reproduce:

    1. Bookmark a page
    2. Open about:bookmarks
    3. Drag the bookmark to Other Bookmarks
    4. Set up sync
    5. Sync with another machine

  • Actual result: On the another machine, the bookmark appears on the bookmark toolbar

  • Expected result: it should be synced into Other Bookmarks folder and should not appear on the bookmark toolbar

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.15.400 milestone May 15, 2017
@diracdeltas diracdeltas self-assigned this May 18, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@diracdeltas
Copy link
Member

seems this is due to parentFolderId being -1 for 'Other Bookmarks', which sync does not recognize as a valid value

diracdeltas added a commit to brave/sync that referenced this issue Jun 2, 2017
@diracdeltas
Add hideInToolbar field to api.proto bookmarks
ff049c3 
needed for brave/browser-laptop#8024
@diracdeltas diracdeltas mentioned this issue Jun 2, 2017
Merged
diracdeltas added a commit to brave/sync that referenced this issue Jun 2, 2017
@diracdeltas
Add hideInToolbar field to api.proto bookmarks
d915811 
needed for brave/browser-laptop#8024
diracdeltas added a commit to brave/sync that referenced this issue Jun 2, 2017
@diracdeltas
Add hideInToolbar field to api.proto bookmarks
ff50279 
needed for brave/browser-laptop#8024
diracdeltas added a commit that referenced this issue Jun 2, 2017
@diracdeltas
Fix syncing bookmarks in 'Other bookmarks' folder
03f416b 
fix #8024

Test Plan:
1. in about:bookmarks, right-click on 'Other bookmarks' and add a folder.
2. enable sync
3. open pyramid 1 and sync to pyramid 0
4. the bookmark folder from pyramid 0 should appear in 'Other bookmarks' in pyramid 1
@diracdeltas diracdeltas mentioned this issue Jun 2, 2017
Merged
7 tasks
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

it is not possible to confirm the bug was fixed as you cannot drag and drop the bookmark to Other Bookmarks.

@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
@diracdeltas
Copy link
Member

@luixxiul per test plan in #9216 (comment), you can right-click on "other bookmarks" to add a folder (not a bookmark though)

This was referenced Jul 27, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Fix syncing bookmarks in 'Other bookmarks' folder brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @LaurenWags