Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enabling show include site with autoinclude off shows payment info page when refreshed #8079

Closed
srirambv opened this issue Apr 5, 2017 · 0 comments
Closed

Enabling show include site with autoinclude off shows payment info page when refreshed #8079

srirambv opened this issue Apr 5, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.0

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 5, 2017 •
edited by cezaraugusto
Loading

Test plan

#8082 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Enabling show include site with autoinclude off messes up payment page

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    master

  • Steps to reproduce:

    1. Build of master and enable payments
    2. Visit any site so that it gets listed in the payment page
    3. Disable autoinclude switch to disabled the website entry from step 2
    4. Turn on show only included site switch and reload the page, shows payment info page along with the switches which work normal

  • Actual result:
    Enabling show include site with autoinclude off shows payment info page when refreshed

  • Expected result:
    Should show the payment page instead of info

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    N/A

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes @NejcZdovc confirmed it on macOS

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image
    image

  • Any related issues:
    cc: @NejcZdovc
@srirambv srirambv added this to the 0.14.2 milestone Apr 5, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 5, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 5, 2017
@NejcZdovc
Fixes empty data in the sort table
42ce680 
Resolves brave#8079

Auditors: @bsclifton

Test Plan:
- clean profile and enable payments
- visit any site so that it gets listed in the payment page
- exclude newly added site
- turn on show only included site switch and reload the page
@NejcZdovc NejcZdovc mentioned this issue Apr 5, 2017
Merged
4 tasks
cezaraugusto pushed a commit that referenced this issue Apr 6, 2017
@NejcZdovc @cezaraugusto
Fixes empty data in the sort table (#8082)
9fb5061 
Resolves #8079

Auditors: @bsclifton

Test Plan:
- clean profile and enable payments
- visit any site so that it gets listed in the payment page
- exclude newly added site
- turn on show only included site switch and reload the page
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @cezaraugusto @NejcZdovc @srirambv