Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed white tab text on dark tab background which is difficult to read #8115

Closed
bradleyrichter opened this issue Apr 7, 2017 · 1 comment
Closed

Fixed white tab text on dark tab background which is difficult to read #8115

bradleyrichter opened this issue Apr 7, 2017 · 1 comment
Assignees
@cezaraugusto
Labels
accessibility bug design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 7, 2017 •
edited by luixxiul
Loading

Old title: white tab text on dark tab background is difficult to read #8115 (comment)

Test plan

on macOS only

  1. Ensure theme colors are shown for tabs
  2. Visit https://www.theatlantic.com/
  3. Confirm the text is easy enough to read / that it matches the after spec (below)

Original issue description

The font weight may need to change for the white tab text label case.
@bradleyrichter bradleyrichter added accessibility bug design A design change, especially one which needs input from the design team. labels Apr 7, 2017
@bradleyrichter bradleyrichter added this to the 0.14.3 milestone Apr 7, 2017
@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Apr 7, 2017 •
edited
Loading

@cezaraugusto I found a solution:

before (on Mac):
image

after (on Mac):
image

So, the weight should be 600, only for the selected tab which is displaying white text based on the BG color threshold.

This was tested to solve the mac issue and had no negative effect on Windows although the improvement is barely noticeable.

cc @bsclifton

@cezaraugusto cezaraugusto mentioned this issue Apr 10, 2017
Merged
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.3 Apr 12, 2017
bsclifton pushed a commit that referenced this issue Apr 12, 2017
@cezaraugusto @bsclifton
Add fontWeight when tabTitle is white on macOS
4c30321 
- Auditors: @bsclifton
- Fix #8115
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title white tab text on dark tab background is difficult to read Fixed white tab text on dark tab background which is difficult to read Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
accessibility bug design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @bradleyrichter @srirambv