Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added temporary notice to sync prefs page regarding mobile sync and Beta label #8121

Closed
bradleyrichter opened this issue Apr 7, 2017 · 5 comments · Fixed by #8131 or #8198
Closed

Added temporary notice to sync prefs page regarding mobile sync and Beta label #8121

bradleyrichter opened this issue Apr 7, 2017 · 5 comments · Fixed by #8131 or #8198
Labels
design A design change, especially one which needs input from the design team. feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 7, 2017 •
edited by luixxiul
Loading

Old title: Add temporary notice to sync prefs page regarding mobile sync, + Beta label #8121 (comment)

Test plan

#8131 (comment)

image

string text:

Note: Sync for iOS and Android is still being completed and will be released soon.

(Beta label can be copied from Brave Payments label.)
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/sync labels Apr 7, 2017
@bradleyrichter bradleyrichter added this to the 0.14.2 milestone Apr 7, 2017
diracdeltas added a commit that referenced this issue Apr 8, 2017
@diracdeltas
add sync beta message
510667f 
fix #8121

test plan:
1. go to about:preferences#sync
2. you should see text saying that sync is still being completed
@diracdeltas diracdeltas mentioned this issue Apr 8, 2017
Merged
4 tasks
@luixxiul
Copy link
Contributor

There is no beta label above the Sync.

clipboard01

@luixxiul luixxiul reopened this Apr 10, 2017
@diracdeltas diracdeltas removed their assignment Apr 10, 2017
@diracdeltas
Copy link
Member

The mockup is inconsistent with the Brave Payments beta logo.
screen shot 2017-04-10 at 5 36 58 pm

@bradleyrichter
Copy link
Contributor Author

doh! my bad...sorry. just copy BP Beta...

diracdeltas added a commit that referenced this issue Apr 10, 2017
@diracdeltas
fix 'beta' logo alignment, add it to sync tab
9bd3941 
address #8121 (comment) and makes the logo look the same on sync and payments tabs
@diracdeltas
Copy link
Member

the payments logo alignment seems wrong. i'll fix that too

@diracdeltas diracdeltas mentioned this issue Apr 10, 2017
Merged
4 tasks
@bradleyrichter
Copy link
Contributor Author

@diracdeltas thanks!

bsclifton pushed a commit that referenced this issue Apr 10, 2017
@diracdeltas @bsclifton
fix 'beta' logo alignment, add it to sync tab
639f072 
address #8121 (comment) and makes the logo look the same on sync and payments tabs
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Apr 17, 2017
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Add temporary notice to sync prefs page regarding mobile sync, + Beta label Added temporary notice to sync prefs page regarding mobile sync and Beta label Apr 25, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Nov 2, 2017
@petemill
Hide windows until they are either rendered or a timeout expires
15ce004 
Fix brave#8121
petemill added a commit that referenced this issue Nov 2, 2017
@petemill
Hide windows until they are either rendered or a timeout expires
426a5c3 
Fix #8121
@petemill petemill mentioned this issue Nov 2, 2017
Merged
8 tasks
petemill added a commit that referenced this issue Nov 7, 2017
@petemill
Hide windows until they are either rendered or a timeout expires
59f43c0 
Fix #8121
bsclifton pushed a commit that referenced this issue Nov 20, 2017
@petemill @bsclifton
Hide windows until they are either rendered or a timeout expires
ad50233 
Fix #8121
petemill added a commit that referenced this issue Nov 21, 2017
@petemill
Hide windows until they are either rendered or a timeout expires.
d3efb89 
Separates parsing of APP_NEW_WINDOW action properties, and window creation / visibility logic.
Moves window creation logic to windows API.
Creates tests for existing APP_NEW_WINDOW action handler logic in windowsReducer
Creates tests for new windows.createWindow logic
Fixes test for downloadsReducer with not restoring a stub required by windowsReducer test

Fix #8121
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
6 participants
@diracdeltas @alexwykoff @luixxiul @cezaraugusto @bradleyrichter @srirambv