This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed invisible pinned tab after upgrade #8190
Assignees
Labels
Milestone
Comments
|
++ on this; I can re-add items back, but after quitting and re-launching Brave, all but one of the pinned tabs are removed |
|
They site entries still have the appropriate tags (ex: The |
bsclifton
added a commit
that referenced
this issue
Apr 11, 2017
At time addFrame is called, location isn't known which causes the check (which is removed by this commit) to only allow one pinned tab through (since url is undefined). The rest of the pinned tabs were dropped. This check is not needed. Realistically, our sites map already has unique keys and we only need to check if the pinned site is unique when a new one is added (check is in app/browser/tabs). Fixes #8190 Auditors: @bbondy Test Plan: 1. Pin multiple sites 2. Exit 3. Re-launch and verify sites are still pinned
bsclifton
added a commit
that referenced
this issue
Apr 11, 2017
At time addFrame is called, location isn't known which causes the check (which is removed by this commit) to only allow one pinned tab through (since url is undefined). The rest of the pinned tabs were dropped. This check is not needed. Realistically, our sites map already has unique keys and we only need to check if the pinned site is unique when a new one is added (check is in app/browser/tabs). Fixes #8190 Auditors: @bbondy Test Plan: 1. Pin multiple sites 2. Exit 3. Re-launch and verify sites are still pinned
This was referenced Apr 13, 2017
This was referenced Apr 21, 2017
alexwykoff
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
70ff720
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Pinned tabs
Platform (Win7, 8, 10? macOS? Linux distro?):
macOS
Brave Version (revision SHA):
0.14.2 Preview 2
Steps to reproduce:
Actual result:
We can only see one pined tab
Expected result:
There should be 4 visible pinned tab
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Is this an issue in the currently released version?
Can this issue be consistently reproduced?
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Kapture 2017-04-10 at 8.37.40.mp4.zip
The text was updated successfully, but these errors were encountered: