Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed download of torrent files #8452

Closed
NejcZdovc opened this issue Apr 23, 2017 · 5 comments
Closed

Fixed download of torrent files #8452

NejcZdovc opened this issue Apr 23, 2017 · 5 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 23, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When you disable Torrent Viewer, torrent download is still routed through it

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    b2e4b71

  • Steps to reproduce:

    1. disable Torrent Viewer in preferences
    2. go to https://webtorrent.io/free-torrents/
    3. download Big Buck Bunny torrent file
  • Actual result:
    image

  • Expected result:
    torrent is downloaded

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

  • Any related issues:
    Support .torrent files in Torrent Viewer #7351

@bsclifton
Copy link
Member

Updated to be not-blocking because WebTorrent has to be disabled in order to get error. Happy path works fine

This does need to be fixed though- but I don't believe it should block the release

@NejcZdovc
Copy link
Contributor Author

@bsclifton why I think it should be blocking is if you don't want to use torrent viewer because of X reason, you can't use torrent files at all.

@bsclifton
Copy link
Member

@NejcZdovc Good point- are you able to right click and choose "Save Link As..."? I believe this should work

The fix for this issue may be easy... WebTorrent logic (filtering, etc) should be ignored if the extension is disabled. For example, the code in https://github.com/brave/browser-laptop/blob/master/app/browser/webtorrent.js

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Apr 24, 2017

@bsclifton "Save Link As..." is not working, because we get the same error as we did before I implemented this one #8246 for a regular download in torrent viewer. So we need to fix this scenario as well

@NejcZdovc
Copy link
Contributor Author

Created a new issue for it #8463

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 24, 2017
Resolves brave#8452

Auditors: @bsclifton

Test Plan:
- disable Torrent Viewer in preferences
- go to https://webtorrent.io/free-torrents/
- download Big Buck Bunny torrent file
bsclifton added a commit that referenced this issue Apr 24, 2017
Fixes torrent download when torrent viewer is disabled
bsclifton pushed a commit that referenced this issue Apr 24, 2017
Resolves #8452

Auditors: @bsclifton

Test Plan:
- disable Torrent Viewer in preferences
- go to https://webtorrent.io/free-torrents/
- download Big Buck Bunny torrent file
@alexwykoff alexwykoff changed the title Download torrent file Fixed download of torrent files Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants