Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fingerprinting protection should distinguish between first and third party #9029

Closed
diracdeltas opened this issue May 24, 2017 · 5 comments · Fixed by #10181
Closed

Fingerprinting protection should distinguish between first and third party #9029

diracdeltas opened this issue May 24, 2017 · 5 comments · Fixed by #10181
Assignees
@diracdeltas
Labels
design A design change, especially one which needs input from the design team. feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 24, 2017 •
edited by bsclifton
Loading

Test plan

  1. Verify that by default (new profile) 3rd party fingerprinting is enabled
  2. Visit https://jsfiddle.net/bkf50r8v/13/
  3. Fingerprint should be blocked

Original issue description

Fingerprinting protection should have 3 options: block all, block third-party, and none. In the future, we should enable 'block third party' by default for all users. Users who currently have FP set to 'on' will be transitioned to 'block all'.

This supercedes #8142 and is related to #4621 / #2965.

cc @bradleyrichter on design for the Shields panel
@diracdeltas diracdeltas added design A design change, especially one which needs input from the design team. feature/shields labels May 24, 2017
@diracdeltas diracdeltas added this to the 0.16.100 milestone May 24, 2017
@diracdeltas diracdeltas self-assigned this May 24, 2017
@diracdeltas diracdeltas modified the milestones: 0.16.200, 0.16.100 May 24, 2017
@diracdeltas
Copy link
Member Author

mockup #9016 (comment)

@diracdeltas
Copy link
Member Author

diracdeltas commented May 24, 2017 •
edited
Loading

@bradleyrichter thoughts on what this should look like in the non-compact version? i was imagining 2 columns with the select boxes in one column and the switches in the other

@bradleyrichter
Copy link
Contributor

@diracdeltas The compact version will most likely becomes the new version as it solves some l10n problems that are occurring in the 2-column layout.

It is also easier to add or change shields.

@alexwykoff alexwykoff removed this from the 0.18.x (Developer Channel) milestone Jun 13, 2017
@diracdeltas diracdeltas added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Jul 18, 2017
diracdeltas added a commit that referenced this issue Jul 28, 2017
@diracdeltas
add 3rd party fingerprinting block option
48f8b5f 
fix #9029

TODO: add and fix tests
@diracdeltas diracdeltas mentioned this issue Jul 28, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Aug 2, 2017
@diracdeltas
add 3rd party fingerprinting block option
0dacae2 
fix #9029
diracdeltas added a commit that referenced this issue Aug 4, 2017
@diracdeltas
add 3rd party fingerprinting block option
fb3f28e 
fix #9029
luixxiul pushed a commit that referenced this issue Aug 5, 2017
Polish braveryPanel.js on fb3f28e for #10181
bcdfa30 
Also:
- Add globalStyles.appIcons.question

Addresses #9029

Auditors: @cezaraugusto

Test Plan:
1. Open about:preferences#shields
2. Enable compact panel
3. Open https://twitter.com
4. Open compact panel
5. Make sure the fp block pulldown is placed properly
6. Disable compact panel
7. Open twitter.com again
8. Open the default panel
9. Make sure the fp pulldown is placed properly
@luixxiul luixxiul mentioned this issue Aug 14, 2017
Closed
diracdeltas added a commit that referenced this issue Aug 15, 2017
@diracdeltas
add 3rd party fingerprinting block option
b8105cc 
fix #9029
diracdeltas pushed a commit that referenced this issue Aug 15, 2017
@diracdeltas
Polish braveryPanel.js on fb3f28e for #10181
c7e5c8c 
Also:
- Add globalStyles.appIcons.question

Addresses #9029

Auditors: @cezaraugusto

Test Plan:
1. Open about:preferences#shields
2. Enable compact panel
3. Open https://twitter.com
4. Open compact panel
5. Make sure the fp block pulldown is placed properly
6. Disable compact panel
7. Open twitter.com again
8. Open the default panel
9. Make sure the fp pulldown is placed properly
@luixxiul
Copy link
Contributor

luixxiul commented Aug 15, 2017 •
edited
Loading

I assume many webcompat issues can be closed thanks to this implementation :-D

@Jacalz
Copy link
Contributor

Jacalz commented Aug 15, 2017

Great, Wouldn’t it be good to remove all site specific fingerprinting fixes that can be solved by third party fingerprinting?
That will make first party more secure since many sites technically has fingerprinting disabled 😉

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@diracdeltas @dfperry5
add 3rd party fingerprinting block option
a18e847 
fix brave#9029
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@dfperry5
Polish braveryPanel.js on fb3f28e for brave#10181
43f171c 
Also:
- Add globalStyles.appIcons.question

Addresses brave#9029

Auditors: @cezaraugusto

Test Plan:
1. Open about:preferences#shields
2. Enable compact panel
3. Open https://twitter.com
4. Open compact panel
5. Make sure the fp block pulldown is placed properly
6. Disable compact panel
7. Open twitter.com again
8. Open the default panel
9. Make sure the fp pulldown is placed properly
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 4, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Jun 6, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
design A design change, especially one which needs input from the design team. feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

add 3rd party fingerprinting block option brave/browser-laptop
8 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @bradleyrichter @srirambv @Jacalz @LaurenWags