Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser crashes by pinning sites, reordering them, and visiting a site via dashboard #9635

Closed
luixxiul opened this issue Jun 21, 2017 · 3 comments · Fixed by #10531
Closed

Browser crashes by pinning sites, reordering them, and visiting a site via dashboard #9635

luixxiul opened this issue Jun 21, 2017 · 3 comments · Fixed by #10531
Labels
bug crash feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 21, 2017 •
edited
Loading

Test plan

#10531 (comment)

Also make sure that the STR below does no longer crash the browser

Describe the issue you encountered: Browser crashes by pinning sites, reordering them, and visiting a site via dashboard.

a

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian

  • Brave Version (revision SHA):

  • Steps to reproduce:

    1. Clear the browser profile
    2. Open https://badssl.com
    3. Open 5 domains from https-everywhere to longextended...
    4. Pin all of them, including the parent tab
    5. Reorder them randomely
    6. Open a dashboard
    7. Click the twitter tile
    8. Pin the twitter tab
    9. Crash!
    10. Restart the browser
    11. Confirm you have the pinned twitter page at the front of the pinned tabs row

  • Actual result: the browser crashes

  • Expected result: it should not

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: Pinning a normal tab causes browser crash but retains the pinned tabs upon restart #9333
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 21, 2017
@benoitjpnet
Copy link

For me it is even more rapid to crash.
Just pin a tab and sometimes it will crash the browser... No need to move the pinned tabs.

Brave: 0.17.13 
rev: f7242c7ae683191b59388f567ccbd13d938b23d4 
Muon: 4.1.7 
libchromiumcontent: 59.0.3071.109 
V8: 5.9.211.38 
Node.js: 7.9.0 
Update Channel: dev 
os.platform: linux 
os.release: 4.9.0-3-amd64 
os.arch: x64

@alexwykoff alexwykoff removed this from the 0.19.x (Beta Channel) milestone Jul 18, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
fa9b09b 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 16, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
6248c7c 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
This was referenced Aug 16, 2017
Merged
Closed
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 26, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f912e34 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a9443d5 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 27, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
f9a6772 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 28, 2017
@petemill
Stop losing pinned tabs in a window when adding or removing another p…
a8e12ab 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bsclifton bsclifton added this to the 0.21.x (Nightly Channel) milestone Aug 28, 2017
bsclifton pushed a commit to petemill/browser-laptop that referenced this issue Aug 29, 2017
@petemill @bsclifton
Stop losing pinned tabs in a window when adding or removing another p…
01008da 
…inned tab

Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117

The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@LaurenWags
Copy link
Member

@petemill I'm seeing twitter tab pinned in step 8 at the end of the pinned tabs, not front (per last step). it remains in the same spot after restarting the browser. Is this expected?
screen shot 2017-12-20 at 5 24 40 pm

@srirambv
Copy link
Collaborator

Same behaviour on Windows also what @LaurenWags mentioned

This was referenced Dec 27, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Jan 2, 2018
Closed
62 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug crash feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
7 participants
@bbondy @benoitjpnet @alexwykoff @luixxiul @bsclifton @srirambv @LaurenWags