Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

adding a bookmarks folder makes the browser unresponsive #9745

Closed
diracdeltas opened this issue Jun 28, 2017 · 1 comment · Fixed by #9746
Closed

adding a bookmarks folder makes the browser unresponsive #9745

diracdeltas opened this issue Jun 28, 2017 · 1 comment · Fixed by #9746

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 28, 2017

Test plan

#9746 (comment)


master and 0.18.x are failing with

  1) Syncing bookmarks "before all" hook:
     WaitUntilTimeoutError: element ([data-l10n-id="done"]) still not visible after 10000ms
      at isVisible("[data-l10n-id="done"]") - waitForVisible.js:37:22
  2) Syncing bookmarks from an existing profile "before all" hook:
     WaitUntilTimeoutError: element ([data-l10n-id="done"]) still not visible after 10000ms
      at isVisible("[data-l10n-id="done"]") - waitForVisible.js:37:22

it turns out this is because adding a bookmarks folder causes a fatal browser error (see comment below).

STR:

  1. open fresh browser profile
  2. right-click to add a bookmark folder. click 'done'.
  3. the browser is unresponsive and you can't open any more tabs or change tabs
@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 28, 2017
@diracdeltas diracdeltas self-assigned this Jun 28, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented Jun 28, 2017

Uncaught TypeError: Cannot read property 'get' of undefined
    at mergeProps (localhost:8080/gen/app.entry.js:75084)
    at buildPropsImpl (localhost:8080/gen/app.entry.js:73319)
    at ReduxComponent.buildProps (localhost:8080/gen/app.entry.js:73391)
    at ReduxComponent.checkForUpdates (localhost:8080/gen/app.entry.js:73356)
    at WindowStore.EventEmitter.emit (localhost:8080/gen/app.entry.js:37228)
    at WindowStore.emitChanges (localhost:8080/gen/app.entry.js:63842)
    at doAction (localhost:8080/gen/app.entry.js:64475)
    at callbacks.forEach (localhost:8080/gen/app.entry.js:41083)
    at Array.forEach (<anonymous>)
    at AppDispatcher.dispatchToOwnRegisteredCallbacks (localhost:8080/gen/app.entry.js:41082)

@diracdeltas diracdeltas changed the title syncing bookmarks test failure bookmarks test failure Jun 28, 2017
@diracdeltas diracdeltas changed the title bookmarks test failure adding a bookmarks folder makes the browser unresponsive Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.