Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinning a PDF tab causes it to duplicate #9954

Closed
srirambv opened this issue Jul 11, 2017 · 0 comments · Fixed by #10116
Closed

Pinning a PDF tab causes it to duplicate #9954

srirambv opened this issue Jul 11, 2017 · 0 comments · Fixed by #10116

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jul 11, 2017

Test plan

#10116 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Pinning a PDF tab causes it to duplicate

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.17.15
rev 39009b8
Muon 4.1.8
  • Steps to reproduce:

    1. Visit http://orimi.com/pdf-test.pdf
    2. Pin the tab
    3. Pinned tab gets duplicated
  • Actual result:
    Pinning a PDF tab causes it to duplicate

  • Expected result:
    Should not duplicate

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes verified from 0.16.9

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@srirambv srirambv added this to the 0.20.x (Nightly Channel) milestone Jul 11, 2017
@diracdeltas diracdeltas self-assigned this Jul 18, 2017
diracdeltas added a commit that referenced this issue Jul 24, 2017
fix #9954

Test Plan:
npm run test -- --grep='Pins an existing frame'
try pinning a PDF frame. it should not be duplicated
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
fix brave#9954

Test Plan:
npm run test -- --grep='Pins an existing frame'
try pinning a PDF frame. it should not be duplicated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.