Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix PDF pinned tabs being duplicated #10116

Merged
merged 1 commit into from
Aug 6, 2017
Merged

fix PDF pinned tabs being duplicated #10116

merged 1 commit into from
Aug 6, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 24, 2017

fix #9954

Test Plan:
npm run test -- --grep='Pins an existing frame'
try pinning a PDF frame. it should not be duplicated

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #9954

Test Plan:
npm run test -- --grep='Pins an existing frame'
try pinning a PDF frame. it should not be duplicated
@diracdeltas diracdeltas added this to the 0.20.x (Nightly Channel) milestone Jul 24, 2017
@diracdeltas diracdeltas self-assigned this Jul 24, 2017
@codecov-io
Copy link

codecov-io commented Jul 24, 2017

Codecov Report

Merging #10116 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #10116      +/-   ##
==========================================
+ Coverage   52.77%   52.77%   +<.01%     
==========================================
  Files         227      227              
  Lines       20138    20139       +1     
  Branches     3223     3223              
==========================================
+ Hits        10628    10629       +1     
  Misses       9510     9510
Flag Coverage Δ
#unittest 52.77% <50%> (ø) ⬆️
Impacted Files Coverage Δ
app/browser/windows.js 17.89% <50%> (+0.32%) ⬆️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks for the test

@cezaraugusto cezaraugusto merged commit 619c700 into master Aug 6, 2017
@cezaraugusto cezaraugusto deleted the fix/9954 branch August 6, 2017 21:13
cezaraugusto added a commit that referenced this pull request Aug 6, 2017
fix PDF pinned tabs being duplicated
@bsclifton
Copy link
Member

Awesome, great job on this 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinning a PDF tab causes it to duplicate
5 participants