Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add support for dynamic breakpoint for tabs #10134

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Add support for dynamic breakpoint for tabs #10134

merged 2 commits into from
Aug 15, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jul 26, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Please see #9779 for integrated manual test plan;

  1. Set max tabs to 6
  2. Open 7 tabs
  3. Two tab sets, close the only tab in 2nd tab set
  4. Tabs in first tab set should not have a fixed close icon
npm run test -- --grep="tabUtil"
npm run test -- --grep="hasFixedCloseIcon"
npm run test -- --grep="hasRelativeCloseIcon"

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cezaraugusto cezaraugusto added this to the 0.19.x (Developer Channel) milestone Jul 26, 2017
@cezaraugusto cezaraugusto self-assigned this Jul 26, 2017
@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #10134 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10134   +/-   ##
=======================================
  Coverage   54.33%   54.33%           
=======================================
  Files         245      245           
  Lines       21156    21156           
  Branches     3260     3260           
=======================================
  Hits        11495    11495           
  Misses       9661     9661
Flag Coverage Δ
#unittest 54.33% <100%> (ø) ⬆️
Impacted Files Coverage Δ
app/common/state/tabContentState.js 99.09% <ø> (ø) ⬆️
app/renderer/components/styles/global.js 100% <ø> (ø) ⬆️
app/renderer/lib/tabUtil.js 100% <100%> (ø) ⬆️

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Aug 7, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Aug 7, 2017

the milestone was moved to the latest one to test the change well.

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan works.

@luixxiul
Copy link
Contributor

@srirambv mind reproducing the issue #9799 on your environment?

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested (before and after change)- works great 😄 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants