Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes Other bookmarks not being usable #10610

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 21, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #10157
Resolves #4202

Auditors:

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Aug 21, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 21, 2017
@NejcZdovc
Copy link
Contributor Author

PR is blocked by #10325, because we change some logic in it

@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #10610 into master will decrease coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master   #10610      +/-   ##
==========================================
- Coverage   54.19%   54.15%   -0.05%     
==========================================
  Files         255      255              
  Lines       22079    22081       +2     
  Branches     3448     3449       +1     
==========================================
- Hits        11966    11958       -8     
- Misses      10113    10123      +10
Flag Coverage Δ
#unittest 54.15% <88.88%> (-0.05%) ⬇️
Impacted Files Coverage Δ
app/common/lib/bookmarkFoldersUtil.js 97.05% <ø> (ø) ⬆️
app/common/lib/bookmarkUtil.js 99.32% <ø> (ø) ⬆️
...nderer/components/bookmarks/addEditBookmarkForm.js 20.32% <ø> (ø) ⬆️
app/common/state/bookmarkFoldersState.js 74.8% <100%> (ø) ⬆️
app/common/state/bookmarksState.js 80.62% <83.33%> (-0.33%) ⬇️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.49% <0%> (-0.31%) ⬇️

Resolves brave#10157
Resolves brave#4202

Auditors:

Test Plan:
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 8d76701 into brave:master Sep 28, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants