Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Correct a mockery path that was preventing forcing the darwin platform in windowsTest #12091

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

petemill
Copy link
Member

This was causing unittests to fail on linux and windows

Fix #12090

Issue was introduced with #11764 which was merged to master, 0.21.x and 0.20.x

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
unit tests pass

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.20.x (Beta Channel) milestone Nov 24, 2017
@petemill petemill self-assigned this Nov 24, 2017
@codecov-io
Copy link

codecov-io commented Nov 24, 2017

Codecov Report

Merging #12091 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12091      +/-   ##
==========================================
+ Coverage   54.53%   54.56%   +0.03%     
==========================================
  Files         275      275              
  Lines       26153    26153              
  Branches     4196     4196              
==========================================
+ Hits        14263    14271       +8     
+ Misses      11890    11882       -8
Flag Coverage Δ
#unittest 54.56% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
app/browser/windows.js 37.53% <0%> (+2.09%) ⬆️

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++, thanks for fixing it

@NejcZdovc NejcZdovc merged commit 82544bb into master Nov 24, 2017
NejcZdovc added a commit that referenced this pull request Nov 24, 2017
Correct a mockery path that was preventing forcing the darwin platform in windowsTest
NejcZdovc added a commit that referenced this pull request Nov 24, 2017
Correct a mockery path that was preventing forcing the darwin platform in windowsTest
@NejcZdovc
Copy link
Contributor

master 82544bb
0.21 3ff52e3
0.20 166cb82

@bsclifton bsclifton deleted the fix/12090 branch November 24, 2017 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants