Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Block empty containers #13540

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Block empty containers #13540

merged 1 commit into from
Apr 6, 2018

Conversation

jonathansampson
Copy link
Collaborator

Submitter Checklist:

Resolves #11730

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Navigate to marketwatch.com
  2. Confirm that ads and ad-containers are not shown

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

@NejcZdovc NejcZdovc added this to the 0.22.x Release 2 (Beta Channel) milestone Apr 5, 2018
@bsclifton bsclifton modified the milestones: 0.22.x Release 2 (Beta Channel), 0.22.x Release 3 Apr 6, 2018
@bsclifton bsclifton self-requested a review April 6, 2018 20:39
@codecov-io
Copy link

Codecov Report

Merging #13540 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13540      +/-   ##
==========================================
- Coverage   56.78%    56.6%   -0.18%     
==========================================
  Files         285      284       -1     
  Lines       29038    28675     -363     
  Branches     4803     4744      -59     
==========================================
- Hits        16488    16231     -257     
+ Misses      12550    12444     -106
Flag Coverage Δ
#unittest 56.6% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
app/siteHacks.js 48.93% <0%> (-26.83%) ⬇️
js/lib/request.js 28.78% <0%> (-9.1%) ⬇️
app/browser/api/ledger.js 59.67% <0%> (-2.26%) ⬇️
app/common/state/ledgerState.js 84.26% <0%> (-0.69%) ⬇️
app/browser/windows.js 32.99% <0%> (-0.67%) ⬇️
app/cmdLine.js 40% <0%> (-0.57%) ⬇️
js/actions/appActions.js 18.59% <0%> (-0.44%) ⬇️
app/sessionStore.js 88.22% <0%> (-0.19%) ⬇️
app/browser/reducers/tabsReducer.js 40% <0%> (-0.06%) ⬇️
js/constants/appConstants.js 100% <0%> (ø) ⬆️
... and 14 more

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄 👍

@bsclifton bsclifton merged commit 99c1df9 into master Apr 6, 2018
@bsclifton bsclifton deleted the issue-11730 branch April 6, 2018 20:48
bsclifton added a commit that referenced this pull request Apr 6, 2018
bsclifton added a commit that referenced this pull request Apr 6, 2018
@bsclifton
Copy link
Member

master 99c1df9
0.23.x eb8ed69
0.22.x 4200ef6

@mandar-brave
Copy link

@bsclifton looks like this regressed; please confirm if OK to re-open
image

@NejcZdovc
Copy link
Contributor

@mandar-brave this was not shipped yet, it's targeted for single webview release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants