Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move webrtc options from advanced to security prefs #13807

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Apr 11, 2018

fix #13805

Test Plan:

  1. go to about:preferences > Advanced
  2. you shouldn't see webrtc options there
  3. go to about:preferences > security
  4. you should see the webrtc options

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #13805

Test Plan:
1. go to about:preferences > Advanced
2. you shouldn't see webrtc options there
3. go to about:preferences > security
4. you should see the webrtc options
@diracdeltas diracdeltas added this to the 0.22.x Release 3 (Beta channel) milestone Apr 11, 2018
@diracdeltas diracdeltas self-assigned this Apr 11, 2018
@codecov-io
Copy link

codecov-io commented Apr 11, 2018

Codecov Report

Merging #13807 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master   #13807      +/-   ##
==========================================
- Coverage   56.55%   56.54%   -0.01%     
==========================================
  Files         283      283              
  Lines       28799    28798       -1     
  Branches     4774     4774              
==========================================
- Hits        16286    16284       -2     
- Misses      12513    12514       +1
Flag Coverage Δ
#unittest 56.54% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/preferences/advancedTab.js 47.54% <ø> (-0.9%) ⬇️
js/about/preferences.js 61.25% <25%> (-0.36%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! ++

@bsclifton bsclifton merged commit 0b28df1 into master Apr 11, 2018
@bsclifton bsclifton deleted the fix/13805 branch April 11, 2018 23:04
bsclifton added a commit that referenced this pull request Apr 11, 2018
Move webrtc options from advanced to security prefs
@bsclifton
Copy link
Member

bsclifton commented Apr 11, 2018

master 0b28df1
0.23.x 3133520
0.22.x cd75af0

bsclifton added a commit that referenced this pull request Apr 11, 2018
Move webrtc options from advanced to security prefs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move webrtc options from advanced to security pref panel
3 participants