Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Travis job optimisations #14050

Merged
merged 1 commit into from
May 15, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 8, 2018

What was done:

  • optimization of travis file
  • added allowed failures (webdriver tests). This means that PR will now actually get green thick if required jobs are passing.
  • added fast check. This means that travis will only wait for required jobs (unit test, linter and codecov) and as soon as this are done will return response to the PR
  • fixed codecov test

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone May 15, 2018
@NejcZdovc NejcZdovc merged commit 7915c9c into brave:master May 15, 2018
@NejcZdovc NejcZdovc removed this from the 0.22.x Release 3 (Beta channel) milestone May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants