This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Change facebook top tile to github and improve styling of top tiles icons #14073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleyrichter
previously approved these changes
May 9, 2018
bsclifton
reviewed
May 14, 2018
js/data/newTabData.js
Outdated
| 'favicon': `${iconPath}/github.png`, | ||
| 'location': 'https://github.com/brave/', | ||
| 'themeColor': 'rgb(255, 255, 255)', | ||
| 'title': 'Brave Software | Github' |
bsclifton
suggested changes
May 14, 2018
|
The fix have been pushed and squashed now @bsclifton 🙂 |
NejcZdovc
reviewed
May 14, 2018
js/data/newTabData.js
Outdated
| @@ -63,6 +63,6 @@ module.exports.topSites = [ | |||
| 'favicon': `${iconPath}/playstore.png`, | |||
| 'location': 'https://play.google.com/store/apps/details?id=com.brave.browser', | |||
| 'themeColor': 'rgb(241, 241, 241)', | |||
| 'title': 'Brave Browser: Fast AdBlock – Apps para Android no Google Play' | |||
| 'title': 'Brave Browser: Fast AdBlock – Apps for Android not Google Play' | |||
There was a problem hiding this comment.
If I go to the link above it says Brave Browser: Fast AdBlocker - Apps on Google Play. I think we need to update it
There was a problem hiding this comment.
Fixed now with latest commit 👍
|
I noticed that the playstore logo was outdated, so I updated it also 👍 |
Jacalz
requested review from
bradleyrichter
and removed request for
bradleyrichter
|
Thanks for merging 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14072
Submitter Checklist:
git rebase -ito squash commits (if needed).