Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

autoplay notification should follow spec #14132

Merged
merged 1 commit into from
May 15, 2018
Merged

Conversation

cezaraugusto
Copy link
Contributor

Address #8956
Reported in https://twitter.com/BrendanEich/status/996258562346135552

Test Plan:

  • When autoplay notification is visible, button order should be deny/allow and respective actions should be respected.

address #8956
-
this changes the options order from
allow/deny to deny/allow to match other notifcations
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 86dec47 into master May 15, 2018
@cezaraugusto cezaraugusto deleted the autoplay-btn-order branch May 15, 2018 05:40
@cezaraugusto cezaraugusto added this to the Completed work milestone May 15, 2018
@cezaraugusto
Copy link
Contributor Author

tagged as Completed work cc @bsclifton for best prioritization

@bsclifton bsclifton modified the milestones: Completed work, 0.24.x (Nightly Channel) May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants