This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Pulled code from about:history into a new historyUtil module #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Nov 4, 2016
| if (left.get('lastAccessedTime') > right.get('lastAccessedTime')) return -1 | ||
| return 0 | ||
| }).slice(-500) | ||
| .sort(historyUtil.sortTimeDescending) |
There was a problem hiding this comment.
Love to see you pulling things like this out so they are more testable. ++
|
++ |
This was referenced Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixes #5353
This has regressed at least once before; this provides a way (other than web driver) to test the code.
(both previously and this time, problem is immutable vs mutable; ex: ".get method not found", etc)
Auditors: @bbondy
Test Plan: