Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

do not count a transaction-in-progress as a transaction... #5721

Merged
merged 2 commits into from
Nov 22, 2016

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Nov 17, 2016

Auditor: @bbondy

Test Plan:

  • Start with vanilla state, enable ledger payments
  • Fund wallet
  • Quit browser, find reconcileStamp: 14... in ledger-state.json and change the 4 to a 3
  • Start browser wait for payment to be made
  • 'View Payment History... link will not appear until all votes cast.

Fixes #5371

Fixes #5441 (i can’t reproduce it — neither could @ayumi — but i cleaned up a little bit of logic to make it easier to follow.

Fixes #4274 ... use the test plan in that issue.

Fixes #5371

Fixes #5441 (i can’t
reproduce it — neither could @ayumi — but i cleaned up a little bit of
logic to make it easier to follow.
@mrose17 mrose17 added this to the 0.12.11 milestone Nov 17, 2016
@mrose17 mrose17 self-assigned this Nov 17, 2016
@bbondy
Copy link
Member

bbondy commented Nov 19, 2016

@ayumi pls review

@ayumi
Copy link
Contributor

ayumi commented Nov 21, 2016

confirming resolves #4274 (Ledger should track windows created before wallet)

tab performance is similar to master @ 33cbd18 (original report #4274 (comment))

half confirming test plan resolves #5371 (Payment history link should not appear until votes cast).
waiting votes to be cast to confirm the payment history link.

@mrose17
Copy link
Member Author

mrose17 commented Nov 22, 2016

@ayumi - how are we doing on this? thanks!

@ayumi
Copy link
Contributor

ayumi commented Nov 22, 2016

@mrose17 Confirmed successful payment history CSV item.

@mrose17
Copy link
Member Author

mrose17 commented Nov 22, 2016

thanks! i'll do the merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants