Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

initial check-in #5924

Merged
merged 2 commits into from
Nov 30, 2016
Merged

initial check-in #5924

merged 2 commits into from
Nov 30, 2016

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Nov 30, 2016

Auditor: @bsclifton

Test fix for #5788 -

  • from outside the US, go to about:preferences#payments
  • click on Add funds...
  • note that there is no Coinbase decoration at the bottom of the modal window
  • click on Display QR code
  • note that there is no Coinbase decoration at the bottom of the QR code window

Test fix for #4114 -

  • add a console.log() call to the getBalance() function
  • verify that it fires every minute or so when you have about:preferences#payments in a tab somewhere
  • verify that it doesn't fire when you don't have about:preferences#payments in a tab somewhere

For the person who fixes #4720 - when appActions.ledgerRecoveryFailed() is invoked, you will find ledgerState.error filled in

  1. Fixes Coinbase should not be shown in payment modal when bitcoin source is not Coinbase #5788
  2. Fixes Query wallet balance less #4114
  3. Partially addresses Ledger recovery should be aware of network status and give appropriate errors when the connection is down. #4720

1. Fixes #5788
2. Fixes #4114
3. Partially addresses #4720
@mrose17 mrose17 added this to the 0.13.0 milestone Nov 30, 2016
- only perform check if payments are enabled
- check using Array.prototype.some (which returns on first truthy result)

Auditors: @mrose17
@bsclifton
Copy link
Member

bsclifton commented Nov 30, 2016

@mrose17 I pulled the code down and tested. The test for about:preferences#settings works great! I made some very small tweaks which should help (see commit log) and manually tested them

I'll keep an eye on this; ping me when there is more to review 😄

@bsclifton
Copy link
Member

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.