Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

hide-autofill-popup only when webcontent is focused #5959

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 1, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

also fix frontend id typo leads to crash

fix #5939

Auditor: @bridiver

Test plan:

  1. Create an autofill entry
  2. Open https://www.roboform.com/filling-test-all-fields
  3. Click on the field to show autofill suggestion, it should fill the fields after clicking on the suggestion

also fix frontend id typo leads to crash

fix brave#5939

Auditor: @bridiver
@darkdh darkdh added this to the 0.13.0 milestone Dec 1, 2016
@bsclifton bsclifton self-assigned this Dec 1, 2016
@bsclifton
Copy link
Member

bsclifton commented Dec 2, 2016

Nice fix! I confirmed this works as expected! 😄

screenshot showing I'm actually on latest muon (and not using 53!)
screen shot 2016-12-02 at 10 49 06 am

@bsclifton bsclifton merged commit 4df62dd into brave:chromium54 Dec 2, 2016
@luixxiul
Copy link
Contributor

@bbondy Merged to master?

@darkdh
Copy link
Member Author

darkdh commented Dec 21, 2016

It's on master now since 54 has been merged into master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants