This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add layer for topSites to avoid dupe icon/bg color #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @jkup, @bradleyrichter Fix #5868 Test Plan: * Go for a website that have same icon color than background (i.e. YouTube) * Go back to new tab page and ensure tile's background should be 15% lighter
|
I think this solves the invisible icon problem for now until we have a better more permanent solution. |
|
++ |
This was referenced Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Auditors: @bradleyrichter, @jkup
Preview (notice Youtube and trakt.tv with different colors):
The amount of opacity was made arbitrarily and can be changed per request.
Note: this is a global change for topSites and will change opacity color of other sites as well, thus why I opted for white transparency.
Fix #5868
Test Plan: