This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Put back in handler for null/empty context menu detail. This is requi… #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Dec 16, 2016
| @@ -664,6 +664,8 @@ const doAction = (action) => { | |||
| if (action.notify) { | |||
| ipc.send('autofill-popup-hidden', action.tabId) | |||
| } | |||
| } else { | |||
| windowState = windowState.delete('contextMenuDetail') | |||
There was a problem hiding this comment.
I think we should just move L663 here. Just like reverting the part of this commit 7fb2e4c#diff-733d30fbf34816322d3f25dd59c1eb99L651
There was a problem hiding this comment.
@darkdh OK fixed- because I am not sure if the order matters, I moved the delete to above this check
…red in order to hide any ContextMenu object Caused by 7fb2e4c#diff-733d30fbf34816322d3f25dd59c1eb99 Fixes #6236 Auditors: @bridiver, @darkdh Test Plan: 1. Launch Brave and use the kabob / cheeseburger icon 2. Notice the context menu comes up 3. Click anywhere on the screen (outside of the context menu) 4. Notice context menu closes itself
|
Merging... I can implement any other feedback in a follow up; let me know 😄 |
|
Did this fix #6253 too? |
|
@luixxiul it will fix issues with regards to the menu- but I am not sure it fixes the other buttons. I'll update here once I can try |
|
@luixxiul buttons work OK for me? I'm not sure if it's a result of this or not though |
|
CC @srirambv |
This was referenced Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Put back in handler for null/empty context menu detail. This is required in order to hide any ContextMenu object
Caused by 7fb2e4c#diff-733d30fbf34816322d3f25dd59c1eb99
Fixes #6236
Auditors: @bridiver, @darkdh
Test Plan: