Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tweak on PinnedTopSite icon to avoid overflow in new tab page #6286

Merged
merged 1 commit into from
Dec 18, 2016
Merged

Tweak on PinnedTopSite icon to avoid overflow in new tab page #6286

merged 1 commit into from
Dec 18, 2016

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Dec 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits (if needed).

Fix #6281

Auditors: @luixxiul

Test Plan:

  • Go to about:newtab
  • Pin a site
  • Pinned icon should not be overflown by favicon (should be aesthetically correct)

@cezaraugusto cezaraugusto added this to the 0.13.0 milestone Dec 17, 2016
@cezaraugusto cezaraugusto self-assigned this Dec 17, 2016
Fix #6281

Auditors: @luixxiul

Test Plan:

* Go to about:newtab
* Pin a site
* Pinned icon should not be overflown by favicon (should be aesthetically correct)
@luixxiul
Copy link
Contributor

I cannot reproduce the issue nor confirm the fix. Will you please tell me how to?

Also is it expected?

screenshot 2016-12-18 3 41 38

@cezaraugusto
Copy link
Contributor Author

on master, if you pin a defaultSite (hover over tile, hit "pin" icon) like Brave AppStore link, or any other tile that has a big favicon, pinned icon gets 'cuted' (or doesn't even appear at all).

screen shot 2016-12-17 at 17 44 45

about your mention, yes it's expected. Maybe we want to polish pinned background-color for when tile has a darker background (such as Facebook), but not related to the work I did here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/newtab polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants