This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Small fixes of buttons on about:certerror and .noScriptInfo #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6317 - Removed a div from certerror.js - Set margin:.2em and font-size:14px to buttons inside .buttons on about:certerror - Added 5px margin-bottom to .truncate inside .dialogInner of .noScriptInfo Auditors: @bsclifton @bradleyrichter Test Plan 1 1. Open https://expired.badssl.com/ 2. Make sure the buttons have margins Test Plan 2 1. Open https://jsfiddle.net/ 2. Disable JavaScript with the shield 3. Click the NoScript icon 4. Make sure the text has margin-bottom
bsclifton
approved these changes
Dec 21, 2016
This was referenced Dec 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Closes #6317
Auditors: @bsclifton / cc: @bradleyrichter for the size of the margins
Test Plan 1
Test Plan 2