This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix copy version info tooltip #6392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix until we get l10n to work (see #6371)
bbondy
reviewed
Dec 22, 2016
| @@ -43,7 +43,7 @@ class AboutBrave extends React.Component { | |||
| <div className='siteDetailsPageContent aboutAbout'> | |||
| <div className='title'> | |||
| <span className='sectionTitle' data-l10n-id='versionInformation' /> | |||
| <span className='fa fa-clipboard' title='Copy password to clipboard' onClick={this.onCopy} /> | |||
There was a problem hiding this comment.
Something like this should work, but maybe another fix is needed for passing attributes to about pages, I'll merge this in the meantime either way though.
copyToClipboard.title=Copy to clipboard
There was a problem hiding this comment.
Two things ( cc: @liunkae ):
- We're missing
data-l10n-idfor this item. We need it to look like this:
<span data-l10n-id='copyToClipboard' className='fa fa-clipboard' onClick={this.onCopy} /> - When you look at about-brave.html, you'll see that for localization this file uses
app.properties. Inside the en-US version of this file, you'll need to be having something like this:copyToClipboard.title=Copy to clipboard
This was referenced Dec 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix until we get l10n to work (see #6371)