Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only close frame if not already closed on tab #8227

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Only close frame if not already closed on tab #8227

merged 1 commit into from
Apr 11, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Apr 11, 2017 •
edited by bsclifton
Loading

Test Plan:

  • Open new tab and close fast with middle click. Repeat 20 times.

Description

Auditors: @NejcZdovc

Fix #8228

NejcZdovc
NejcZdovc approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't reproduce this bug anymore

@cndouglas cndouglas added this to the 0.14.2 milestone Apr 11, 2017
@bsclifton bsclifton merged commit 3a515d3 into master Apr 11, 2017
@bsclifton bsclifton deleted the closeTabFix branch April 11, 2017 16:26
@NejcZdovc NejcZdovc mentioned this pull request Apr 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@bbondy bbondy

Labels
crash QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Crash when opening/closing tabs really fast
4 participants
@bbondy @NejcZdovc @bsclifton @cndouglas