Provide a swipe navigation distance setting for users to config along with swipe indicator #9617

darkdh · 2017-06-20T21:54:52Z

fixes #9615

Auditors: @cezaraugusto, @bbondy, @bradleyrichter

Test Plan:

Adjust swipe navigation sesitivity setting in
about:preferences#advanced
And swipe to navigate by different settings

It shouldn't show up on linux and window

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

Also add swipe indicator

bradleyrichter · 2017-06-20T23:55:30Z

@darkdh I think the slowest setting greatly improves on the accidental swipe issue we are having now. It felt natural as well. So I don't think the slider is necessary right now but keep it for other future needs?

darkdh · 2017-06-21T00:34:10Z

@bradleyrichter, we can make the slowest setting default but some users like swiping faster or even slower. We can't satisfy all users with one setting so we allow them to customize.
I'm a fast swiper and I believe @diracdeltas is even faster.

darkdh · 2017-06-23T18:59:27Z

also fix #2477

cezaraugusto · 2017-06-24T20:55:19Z

feature works but sometimes instead of swiping to the next/previous page it opens the context menu. I don't have proper str

cezaraugusto · 2017-06-24T20:58:46Z

which is tricky given it also happens with Chrome

cezaraugusto · 2017-06-24T21:08:13Z

btw what's the take on #9617 (comment) @bradleyrichter @darkdh ?

@cezaraugusto

with swipe progress indicator fixes #9615 #2477 Auditors: @cezaraugusto, @bbondy, @bradleyrichter Test Plan: 1. Adjust swipe navigation distance setting in about:preferences#advanced 2. And swipe to navigate by different settings It shouldn't show up on linux and window

darkdh · 2017-06-29T18:09:27Z

@cezaraugusto it is addressed per discussion I had with @bradleyrichter yesterday
�This PR is ready for review again.

cezaraugusto · 2017-07-02T03:11:42Z

app/renderer/components/navigation/navigator.js

+    props.swipeLeftPercent = swipeLeftPercent ? (swipeLeftPercent + 1) * 1.2 : 1
+    props.swipeRightPercent = swipeRightPercent ? (swipeRightPercent + 1) * 1.2 : 1
+    // 0.85 is the default button opacity in less/navigationBar.less
+    // Remove this magic number once we migrate to Aphrodite


thanks for the comment

cezaraugusto · 2017-07-02T03:14:58Z

app/renderer/components/preferences/advancedTab.js

+          <input type='range' min='1' max='201' step='50' list='swipeDistance'
+            value={getSetting(settings.SWIPE_NAV_DISTANCE, this.props.settings)}
+            onChange={changeSetting.bind(null, this.props.onChangeSetting, settings.SWIPE_NAV_DISTANCE)} />
+          <datalist id='swipeDistance'>


the front-end gods salute you for this great element 😜

cezaraugusto · 2017-07-02T03:22:31Z

app/renderer/components/preferences/advancedTab.js

+
+  swipeNavigation__longLabel: {
+    marginLeft: '5px'
+  },


cezaraugusto

can't wait to start using it, great work +++++++

darkdh added the OS/macOS label Jun 20, 2017

darkdh self-assigned this Jun 20, 2017

darkdh requested review from bbondy, cezaraugusto and bradleyrichter June 20, 2017 21:54

darkdh force-pushed the swipe_nav_sensitivity branch from 244bf63 to 5aff067 Compare June 21, 2017 00:29

darkdh force-pushed the swipe_nav_sensitivity branch 3 times, most recently from 361fe7b to 76e3f20 Compare June 21, 2017 19:23

cezaraugusto added the PR/needs-rebase ۞ label Jun 23, 2017

darkdh force-pushed the swipe_nav_sensitivity branch from 76e3f20 to ece90b3 Compare June 23, 2017 22:54

darkdh removed the PR/needs-rebase ۞ label Jun 23, 2017

darkdh force-pushed the swipe_nav_sensitivity branch from ece90b3 to be52976 Compare June 29, 2017 18:04

darkdh requested a review from bsclifton June 29, 2017 18:09

darkdh changed the title ~~Provide a swipe navigation sensitivity setting for users to config~~ Provide a swipe navigation distance setting for users to config along with swipe indicator Jun 29, 2017

cezaraugusto added this to the 0.20.x (Nightly Channel) milestone Jul 2, 2017

cezaraugusto reviewed Jul 2, 2017

View reviewed changes

app/renderer/components/preferences/advancedTab.js

swipeNavigation__longLabel: {

marginLeft: '5px'

},

Copy link

Contributor

cezaraugusto Jul 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool

cezaraugusto approved these changes Jul 2, 2017

View reviewed changes

cezaraugusto merged commit 8503998 into master Jul 2, 2017

cezaraugusto deleted the swipe_nav_sensitivity branch July 2, 2017 03:23

darkdh mentioned this pull request Jul 2, 2017

Swipe Navigation Sensitivity Setting #9615

Closed

This was referenced Aug 25, 2017

Some visual indicator when swiping to go back or forward. #10663

Closed

Two-finger swipe gesture on macOS should have visual indicator #2477

Closed

darkdh mentioned this pull request Nov 6, 2017

display visual indication of trackpad gesture to "Go back" #11792

Closed

bsclifton mentioned this pull request Feb 14, 2018

Accidentally swiping back on macOS #12658

Closed

cndouglas mentioned this pull request May 2, 2018

Toolbar back button #13988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide a swipe navigation distance setting for users to config along with swipe indicator #9617

Provide a swipe navigation distance setting for users to config along with swipe indicator #9617

darkdh commented Jun 20, 2017 •

edited

Loading

bradleyrichter commented Jun 20, 2017

darkdh commented Jun 21, 2017

darkdh commented Jun 23, 2017 •

edited

Loading

cezaraugusto commented Jun 24, 2017

cezaraugusto commented Jun 24, 2017

cezaraugusto commented Jun 24, 2017

darkdh commented Jun 29, 2017

cezaraugusto Jul 2, 2017

bsclifton Jul 2, 2017

cezaraugusto Jul 2, 2017 •

edited

Loading

cezaraugusto Jul 2, 2017

cezaraugusto left a comment •

edited

Loading

Provide a swipe navigation distance setting for users to config along with swipe indicator #9617

Provide a swipe navigation distance setting for users to config along with swipe indicator #9617

Conversation

darkdh commented Jun 20, 2017 • edited Loading

bradleyrichter commented Jun 20, 2017

darkdh commented Jun 21, 2017

darkdh commented Jun 23, 2017 • edited Loading

cezaraugusto commented Jun 24, 2017

cezaraugusto commented Jun 24, 2017

cezaraugusto commented Jun 24, 2017

darkdh commented Jun 29, 2017

cezaraugusto Jul 2, 2017

Choose a reason for hiding this comment

bsclifton Jul 2, 2017

Choose a reason for hiding this comment

cezaraugusto Jul 2, 2017 • edited Loading

Choose a reason for hiding this comment

cezaraugusto Jul 2, 2017

Choose a reason for hiding this comment

cezaraugusto left a comment • edited Loading

Choose a reason for hiding this comment

darkdh commented Jun 20, 2017 •

edited

Loading

darkdh commented Jun 23, 2017 •

edited

Loading

cezaraugusto Jul 2, 2017 •

edited

Loading

cezaraugusto left a comment •

edited

Loading