From 487188c3e0777feefe2c8a23dfc559f887873083 Mon Sep 17 00:00:00 2001 From: bridiver Date: Thu, 27 Sep 2018 14:41:34 -0700 Subject: [PATCH] remove unused and dangerous apis auditors @darkdh @diracdeltas --- lib/renderer/api/remote.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/renderer/api/remote.js b/lib/renderer/api/remote.js index 170a416f3..9acd43952 100644 --- a/lib/renderer/api/remote.js +++ b/lib/renderer/api/remote.js @@ -292,11 +292,6 @@ ipcRenderer.on('ELECTRON_RENDERER_RELEASE_CALLBACK', function (event, id) { var binding = {} -// Alias to remote.require('electron').xxx. -binding.getBuiltin = function (module) { - return metaToValue(ipcRenderer.sendSync('ELECTRON_BROWSER_GET_BUILTIN', module)) -} - // Get current BrowserWindow. binding.getCurrentWindow = function () { return metaToValue(ipcRenderer.sendSync('ELECTRON_BROWSER_CURRENT_WINDOW')) @@ -331,12 +326,12 @@ binding.unregisterEvents = function (tabID, listener) { GuestViewInternal.removeListener(tabID, listener) } -const deprecatedRemoteAPIs = ['Menu', 'shell', 'screen', 'clipboard', 'session', 'BrowserWindow'] +const deprecatedRemoteAPIs = ['Menu', 'clipboard'] for (var i = 0, len = deprecatedRemoteAPIs.length; i < len; i++) { const name = deprecatedRemoteAPIs[i] Object.defineProperty(binding, name, { get: function () { - return binding.getBuiltin(name) + return metaToValue(ipcRenderer.sendSync('ELECTRON_BROWSER_GET_BUILTIN', name)) } }) }