Implements chrome.windows.create

brave · Sep 5, 2017 · 49afc2b · 49afc2b
1 parent 602f560
commit 49afc2b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/atom/common/api/resources/windows_bindings.js b/atom/common/api/resources/windows_bindings.js
@@ -1,6 +1,7 @@
-var binding = require('binding').Binding.create('windows')
-
-var ipc = require('ipc_utils')
+var ipc = require('ipc_utils');
+var binding = require('binding').Binding.create('windows');
+var process = requireNative('process');
+var extensionId = process.GetExtensionId();
 
 var id = 1;
 
@@ -21,7 +22,7 @@ binding.registerCustomHook(function (bindingsAPI, extensionId) {
   })
 
   apiFunctions.setHandleRequest('create', function (createData, cb) {
-    console.warn('chrome.windows.create is not supported yet')
+    ipc.send('chrome-windows-create', extensionId, createData)
   })
 
   apiFunctions.setHandleRequest('getCurrent', function () {

diff --git a/lib/browser/api/extensions.js b/lib/browser/api/extensions.js
@@ -653,6 +653,10 @@ ipcMain.on('chrome-windows-update', function (evt, responseId, windowId, updateI
   evt.sender.send('chrome-windows-update-response-' + responseId, response)
 })
 
+ipcMain.on('chrome-windows-create', function (evt, extensionId, createData) {
+  process.emit('chrome-windows-create', extensionId, createData)
+})
+
 // chrome.browserAction
 
 ipcMain.on('chrome-browser-action-set-badge-background-color', function (evt, extensionId, details) {