Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Implements chrome.windows.create #295

Merged
merged 5 commits into from
Oct 15, 2017
Merged

Implements chrome.windows.create #295

merged 5 commits into from
Oct 15, 2017

Conversation

jonathansampson
Copy link
Collaborator

Initial work to add support for chrome.windows.create.

Resolves brave/browser-laptop#6789

@darkdh darkdh requested a review from bridiver October 14, 2017 20:24
@@ -21,7 +21,16 @@ binding.registerCustomHook(function (bindingsAPI, extensionId) {
})

apiFunctions.setHandleRequest('create', function (createData, cb) {
console.warn('chrome.windows.create is not supported yet')
var responseId = ++id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using ipc.guid() here. The integer ids can be duplicated across windows. Please update other uses in this file as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have time please also update browser_action_bindings.js in a separate PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like also context_menu_bindings.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed 3a9b420

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure will do

@bbondy bbondy merged commit 2fe761f into master Oct 15, 2017
bbondy added a commit that referenced this pull request Oct 15, 2017
bbondy added a commit that referenced this pull request Oct 15, 2017
@bbondy
Copy link
Member

bbondy commented Oct 15, 2017

master:
2fe761f

4.5.x+62.0.3202.38
ea9f8c5

4.4.x+61.0.3163.100
eaac5c2

@darkdh darkdh added this to the 4.4.29 milestone Oct 15, 2017
@darkdh darkdh deleted the chrome.windows.create branch October 18, 2017 03:55
bridiver pushed a commit that referenced this pull request Oct 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants