This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Trying to address surface synchronization patch #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing these patches from browser_plugin.cc: - bbf2817 - 416dc9c Most of the above patches have already been removed (after single webview) from browser_plugin.cc Chromium 68 has a few patches related to surface synchronization, such as this: https://chromium.googlesource.com/chromium/src/+/98d76dade64f938d939b7930e1de5460b564c2e2%5E%21/ The above Muon patches were to solve brave/browser-laptop#13982 I compiled this change in release mode + ran with 25 tabs (switching tabs with mouse/keyboard). I quit, relaunched, etc. Also turned off tab preview + used debug menu to manually discard tabs and switch back to them. Didn't notice any of the webviews get locked Not sure if this solves the problem, but this patch might not be needed anymore Auditors: @bridiver, @petemill
|
Unfortunately, removing this patch does cause brave/browser-laptop#13982 on Windows |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address brave/browser-laptop#15025
Removing these patches from browser_plugin.cc:
Most of the above patches have already been removed (after single webview) from browser_plugin.cc
Chromium 68 has a few patches related to surface synchronization, such as this:
https://chromium.googlesource.com/chromium/src/+/98d76dade64f938d939b7930e1de5460b564c2e2%5E%21/
The above Muon patches were to solve brave/browser-laptop#13982
I compiled this change in release mode + ran with 25 tabs (switching tabs with mouse/keyboard). I quit, relaunched, etc. Also turned off tab preview + used debug menu to manually discard tabs and switch back to them. Didn't notice any of the webviews get locked
Not sure if this solves the problem, but this patch might not be needed anymore
Auditors:
@bridiver, @petemill