This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Add chrome.contextMenus.create and chrome.contextMenus.removeAll #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this pull request
Oct 26, 2016
fix brave#4689 requires brave/muon#82 Auditors: @bridiver, @jonathansampson Test Plan: n/a
4 tasks
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this pull request
Oct 27, 2016
fix brave#4689 requires brave/muon#82 Auditors: @bridiver, @jonathansampson Test Plan: n/a
|
@bridiver pls review |
bridiver
reviewed
Oct 28, 2016
| @@ -30,6 +30,7 @@ process.on('EXTENSION_READY_INTERNAL', (installInfo) => { | |||
| } | |||
| browserActions.setDefaultBrowserAction(installInfo.id, details) | |||
| addBackgroundPageEvent(installInfo.id, 'chrome-browser-action-clicked') | |||
| addBackgroundPageEvent(installInfo.id, 'chrome-context-menus-clicked') | |||
There was a problem hiding this comment.
this will only add the context menu events if the extension also has a browser action. Just moving it out of the if should be fine
bridiver
reviewed
Oct 28, 2016
| } | ||
| }, | ||
| removeAll: function (cb) { | ||
| var responseId = ++id |
There was a problem hiding this comment.
can we add the extension id to this as well? I know none of the others have it, but we should probably add for all of them because there is a chance of conflict now that we have more than one extension running at the same time
bridiver
reviewed
Oct 28, 2016
| }, | ||
| create: function (properties, cb) { | ||
| console.warn('chrome.contentMenus.create is not supported yet') | ||
| cb && cb() | ||
| var responseId = ++id |
|
feedback addressed in 765646166e1f2e2fa50b7ea90b890b6c2efc0d0a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bridiver, @jonathansampson