Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Display of Valve Proton in Processes view #138

Closed
Eonfge opened this issue Sep 23, 2018 · 6 comments
Closed

[Bug] Display of Valve Proton in Processes view #138

Eonfge opened this issue Sep 23, 2018 · 6 comments
Assignees
Labels

Comments

@Eonfge
Copy link

Eonfge commented Sep 23, 2018

Currently, Q4Wine has partial for Valve Proton processes in it's system. It would be useful if something was done with this in a more constructive manner. See the image:

screenshot from 2018-09-23 11-25-51

There are roughly two options:

  • Hide all Proton processes (The ones without a prefix path)
  • Flag the processes as Proton processes
@brezerk brezerk self-assigned this Sep 24, 2018
@brezerk brezerk added the Bug label Sep 24, 2018
@brezerk
Copy link
Owner

brezerk commented Sep 24, 2018

Thank you for the bug report. I'll take a look on it.

@brezerk
Copy link
Owner

brezerk commented Sep 27, 2018

from what i see Proton is exporting the WINEPREFIX variable:

WINEPREFIX=/home/brezerk/.local/share/Steam/steamapps/compatdata/214730/pfx/

this is good

@brezerk
Copy link
Owner

brezerk commented Sep 27, 2018

in order to control the process, you have to supply all variables like:

 WINEDLLPATH=/home/brezerk/.local/share/Steam/steamapps/common/Proton\ 3.7/dist/lib64/wine WINEPREFIX=/home/brezerk/.local/share/Steam/steamapps/compatdata/214730/pfx/ WINEESYNC=1 /home/brezerk/.local/share/Steam/steamapps/common/Proton\ 3.7/dist/bin/wineserver -k

or you will get ABI mismatch:

wine client error:0: version mismatch 557/560.
Your wineserver binary was not upgraded correctly,
or you have an older one somewhere in your PATH.
Or maybe the wrong wineserver is still running?

@brezerk
Copy link
Owner

brezerk commented Sep 27, 2018

So here is the issue:

Currently q4wine relays on the information present in the q4wine db regarding the wineprefix information:

            execObj.cmdargs = "-kill";
            execObj.execcmd = "wineserver";

            if (!this->runWineBinary(execObj, db_prefix.getName(prefix_path), false)){
                return false;
            }

I think it is not the best solution: since you can have such side-running process in general (not really related to Proton). So I guess I need to change logic a bit: we need to extract the environment variables for the process.

@brezerk
Copy link
Owner

brezerk commented Sep 27, 2018

as for the process list. this commit will fix the process display: 7bfd03f you will be able to control single process via 'Stop current' and 'Renice'. The 'Stop wine' action will require additional fix.

image

@brezerk
Copy link
Owner

brezerk commented Sep 27, 2018

This one 7ef9192 will address the 'Stop wine' action.

Should be all set now. Test please and reopen if needed.

Thanks.

@brezerk brezerk closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants