Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts 8ac39ba #253

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Reverts 8ac39ba #253

merged 1 commit into from
Aug 3, 2023

Conversation

dillonhafer
Copy link
Contributor

Fixes #252

It looks like historically StreetSuffix has always been used to internally generate random sounding street names, where as one would want a StreetSuffix generator to be true street name suffixes we encounter in real life:

[
  Boulevard,
  Place,
  Road,
  Way,
  Terrace,
  Court,
  Lane,
  Circle,
  Trail,
  Avenue,
  Drive,
  Street
]

Perhaps the current StreetSuffix function should be an internal function and the public one generate names from the corresponding list.

@dillonhafer
Copy link
Contributor Author

Also to note, the current data/address street suffixes look very close to what one would think a city suffix would be.

@brianvoe brianvoe merged commit 4d7a52a into brianvoe:master Aug 3, 2023
12 checks passed
@brianvoe
Copy link
Owner

brianvoe commented Aug 3, 2023

v6.23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Street() has odd suffix / space
2 participants