-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Except: pass
in databases metastore
#187
Comments
Do you suggest we try:
to start with, and review the whole "try/except/finally" of this feat+method ? |
@tngTUDOR No, I think he is saying the @mrvisscher Can you give me an example of what kind of error could arise during the SQL transaction? It should be pretty straightforward and I wouldn't have expected any errors there. BTW, this is another thing that should change ASAP - the database and method data (even CFs) will be in the database as well. |
I know this is probably unrelated but some tests in 3.11 @ win arch fail with some "delete" related ops (for projects, not databases): just leaving it here in case this could help out the coverage and / or identification of the reason why we have such test failing |
Yes this was actually what I was suggesting. We had the Database Delete action in the Activity Browser failing silently, and our tests didn't catch it because the exception never came up.
Any error from database lock to whatever, depending on the backend.
Well that's just fantastic. I was discussing this at our side not so long ago as well. Happy to hear that's being planned. |
There is an undefined
Except: pass
in the database deletion procedure. This causes databases to be silently deleted from the metastore regardless of any errors that occurred during actual database deletion from the SQLite database. This leads to ghost databases that are not registered but do still exist.https://github.com/brightway-lca/brightway2-data/blob/main/bw2data/meta.py#L100
The text was updated successfully, but these errors were encountered: