Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build without non-free unrar #674

Closed
bbigam opened this issue Aug 6, 2020 · 1 comment
Closed

Build without non-free unrar #674

bbigam opened this issue Aug 6, 2020 · 1 comment

Comments

@bbigam
Copy link

bbigam commented Aug 6, 2020

Is your feature request related to privacy?

Indirectly, as a FOSS issue.

Is there a patch available for this feature somewhere?

Yes, at Ungoogled Chromium, coming from Debian.
https://github.com/Eloston/ungoogled-chromium/blob/master/patches/core/debian/disable/unrar.patch
https://sources.debian.org/patches/chromium/83.0.4103.116-1%7Edeb10u3/disable/unrar.patch/
Sorry, I'm not sure what the license is, but all Debian patches follow the Debian Free Software Guidelines. Probably same license as Chromium itself.

Describe the solution you would like

Build Bromite with the patch to remove the non-free unrar. My understanding is that unrar is not actually used in Bromite anyway, since Safe Browsing is disabled. It looks like a rather trivial patch, too. It would be another step toward Bromite being fully FOSS, which indirectly helps privacy too.

Describe alternatives you have considered

None, I'm happy with Bromite, this would just be another great feature.

Apologies if this is not posted correctly... it's my first time!

@csagan5
Copy link
Contributor

csagan5 commented Aug 7, 2020

Safe browsing is disabled already in Bromite, so it would never run, but regardless it's necessary to remove all non-free binaries, as much as possible.

Fixed in 84.0.4147.121.

@csagan5 csagan5 closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants