Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

killing CPO tab on Brave browser does not result in warning #938

Closed
shriram opened this issue Nov 19, 2016 · 4 comments
Closed

killing CPO tab on Brave browser does not result in warning #938

shriram opened this issue Nov 19, 2016 · 4 comments

Comments

@shriram
Copy link
Member

shriram commented Nov 19, 2016

When I kill a CPO tab on Chrome, I get a prompt asking me whether I'm sure. On Brave, the tab closes without any warning. [NB: This could be a bug on Brave.] This is on macOS.
@jswrenn
Copy link
Member

jswrenn commented Dec 28, 2016

This is probably related to brave/browser-laptop#4079, which was recently marked as fixed.

@schanzer
Copy link

@shriram still an issue?

@shriram
Copy link
Member Author

shriram commented Nov 13, 2018

I just upgraded to the latest version of Brave, wrote some code, tried to kill the tab…and it died. I did the same in Safari and I got a "are you sure you want to leave this page" warning.

@schanzer
Copy link

Current version of Brave on macOS raises the warning. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shriram @schanzer @jswrenn