Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node tests causing SEGV #22

Closed
dcousens opened this issue Jan 13, 2016 · 4 comments
Closed

Node tests causing SEGV #22

dcousens opened this issue Jan 13, 2016 · 4 comments
Assignees
@indutny
Labels
bug

Comments

@dcousens
Copy link
Member

@calvinmetcalf can you verify?
@dcousens dcousens added the bug label Jan 13, 2016
@fanatid
Copy link
Contributor

fanatid commented Feb 23, 2016 

$ git clone git@github.com:crypto-browserify/pbkdf2.git
...
$ cd pbkdf2
$ npm i
...
$ npm run test
...
    node pbkdf2 pbkdf2-compat pbkdf2 sha1 should throw Bad key length: Segmentation fault (core dumped)
$ node -v
v5.6.0
$ npm -v
3.6.0

@calvinmetcalf
Copy link
Contributor

confirmed, this is actually a node bug... it would seem

@calvinmetcalf
Copy link
Contributor

filing an issue

@calvinmetcalf calvinmetcalf mentioned this issue Feb 23, 2016
Closed
@fanatid fanatid mentioned this issue Feb 24, 2016
Closed
@dcousens dcousens assigned indutny and unassigned calvinmetcalf Feb 24, 2016
@dcousens dcousens mentioned this issue Feb 24, 2016
Merged
@fanatid fanatid mentioned this issue Mar 6, 2016
Merged
@fanatid
Copy link
Contributor

fanatid commented Mar 8, 2016

This issue is not actual now
nodejs/node#5397 merged
NaN check added in #27

@fanatid fanatid closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indutny indutny

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
4 participants
@indutny @dcousens @calvinmetcalf @fanatid