Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timed entity queue should take into account namespace as well as name #801

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Timed entity queue should take into account namespace as well as name #801

merged 4 commits into from
Aug 23, 2024

Conversation

robertcoltheart
Copy link
Contributor

Fixes #800

buehler
buehler reviewed Aug 22, 2024
View reviewed changes
Copy link
Owner

@buehler buehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I only have one thing that I want to discuss. Otherwise, lgtm.

src/KubeOps.Operator/Queue/TimedEntityQueue.cs Outdated Show resolved Hide resolved
@buehler buehler merged commit de986bf into buehler:main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buehler buehler buehler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Cannot requeue objects with the same name in difference namespaces
2 participants
@robertcoltheart @buehler