Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deploy to Heroku" button doesn't work from created repo #1609

Open
andrewculver opened this issue Jul 15, 2024 · 2 comments
Open

"Deploy to Heroku" button doesn't work from created repo #1609

andrewculver opened this issue Jul 15, 2024 · 2 comments

Comments

@andrewculver
Copy link
Contributor

image
@jagthedrummer
Copy link
Contributor

Maybe we just remove the "Deploy to Heroku" button for a configured repo? Or somehow check to see if the repo is public before asking if they want the button?

@gazayas
Copy link
Contributor

gazayas commented Jul 17, 2024

Maybe we just remove the "Deploy to Heroku" button for a configured repo?

I actually like this idea. The original README serves as a primer for getting started with Bullet Train, so it makes sense to me that developers would look at the README and apply any additional configuration (like these deploy buttons) if it's necessary for their use-case, even after the initial setup. We don't necessarily need to have the buttons exist in a new application, as long as we point developers in the right direction.

It may be beneficial to just have solid documentation on how to deploy with each service and link to it in the README too. That would also help to cut down on things to do in bin/configure which would make it quicker/smoother for developers to get setup with a new application.

If we do want the buttons though, I submitted #1614 so developers don't have to write in their repository link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants