Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns didn't align properly on iOS 8.4 #578

Closed
lyf1988 opened this issue Feb 14, 2017 · 4 comments
Closed

Columns didn't align properly on iOS 8.4 #578

lyf1988 opened this issue Feb 14, 2017 · 4 comments

Comments

@lyf1988
Copy link

lyf1988 commented Feb 14, 2017

I am developing a web app using react, and planning to support iOS version down to iOS8.
But I found the Columns did't display properly on iOS8, it seems aligned left instead of display like a table.
If iOS 8 safari is out of support list, please just close this.
Thank you all for providing such good looking and easy to use components.

This is the Screen shot from OSX simulator using safari on iPhone 6 Plus - iOS 8.4.

simulator screen shot 14 feb 2017 03 23 12

This is same page on iPhone 6 Plus - iOS 9.0

simulator screen shot 14 feb 2017 03 30 59

@clauderic
Copy link
Contributor

Issue:

Looks like this is because of the current autoprefixer config being set to last 2 versions.

I went ahead and tested in iOS 8.4 on the simulator and indeed replicated the same behavior on the demo site.

Here's what the generated prefixed CSS currently looks like for Table__row:

screen shot 2017-02-15 at 12 18 01 pm

Notice it's falling back to display: -webkit-box;, which seems to behave differently on Safari iOS 8 and prior.

If I go ahead and set it to display: -webkit-flex; all is well:

screen shot 2017-02-15 at 12 18 35 pm

Possible solutions

@bvaughn Happy to submit a small PR for this if you feel like updating the autoprefixer config is the right way to go here.

Alternatively @lyf1988, if you're using a module bundler like webpack, you can always use your own Autoprefixer config in your webpack loader configuration for css files.

@bvaughn
Copy link
Owner

bvaughn commented Feb 15, 2017

Good catch @clauderic!

If it's as simple as nudging the autoprefixer config, I'd be happy to accept a PR 😄

@bvaughn
Copy link
Owner

bvaughn commented Feb 16, 2017

Fixed with PR #580 (thanks @clauderic!) and will go out soon with 9.0.0

@bvaughn
Copy link
Owner

bvaughn commented Feb 16, 2017

PS just pushed another RC (2) with this change if you'd like to test early~ npm i react-virtualized@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants