Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ignore/exclude folder #7

Open
alexellis opened this issue Feb 24, 2019 · 2 comments
Open

Suggestion: ignore/exclude folder #7

alexellis opened this issue Feb 24, 2019 · 2 comments

Comments

@alexellis
Copy link

It would be ideal to ignore/exclude the text "/vendor/" from any auditing of Golang projects, the same would be true with Node.js projects where we need to exclude "/node_modules/"

Your tool would be about 2-3x as useful with this feature. What do you think?

I did something very similar here, but it'd be good to see it done in a generic way like -exclude="/vendor/".

@bytbox
Copy link
Owner

bytbox commented Feb 24, 2019

This makes sense, but I certainly don't want to have hard-coded pathnames that are excluded. So... would such paths usually be in gitignore? Because it seems reasonable to try and parse gitignore and hgignore.

@alexellis
Copy link
Author

I'm not suggesting hard-coded:

... but it'd be good to see it done in a generic way like -exclude="/vendor/".

.gitignore won't work for Golang projects prior to Go modules since we commit the vendor folder as a rule. A simple exclusion pattern via args would work great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants