Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date label not in label JSON #4472

Open
bcazeaux opened this issue Aug 21, 2024 · 7 comments
Open

Date label not in label JSON #4472

bcazeaux opened this issue Aug 21, 2024 · 7 comments
Labels
backlog Queued in backlog bug Something isn't working Forms

Comments

@bcazeaux
Copy link

bcazeaux commented Aug 21, 2024

Describe the bug

Today, when adding a new DateTime input into a form, it is possible to set a Date Label. Meanwhile, the date label is stored in the json with a "dateLabel" key while a "label" key stays with the default value "datetime". This behavior apply only to DateTime input.

Should the label be directly stored in the label key ?

Steps to reproduce

  1. Add a DateTime input
  2. Change the default label
  3. Your JSON file should look like that :
    {
    "subtype": "date",
    "dateLabel": "myCustomLabel",
    "label": "Date time",

    "type": "datetime",
    "layout": {
    "row": "Row_1d1o9f4",
    "columns": null
    }

Expected behavior

The JSON should look like :
{
"subtype": "date",
"label": "myCustomLabel",
"type": "datetime",
"layout": {
"row": "Row_1d1o9f4",
"columns": null
}

Environment

  • OS: Windows 10
  • Camunda Modeler Version: 5.24.0
  • Execution Platform: Camunda 7.19
  • Installed plug-ins: None

Additional context

No response


Depends on bpmn-io/form-js#1268

@bcazeaux bcazeaux added the bug Something isn't working label Aug 21, 2024
@nikku
Copy link
Member

nikku commented Aug 26, 2024

@bcazeaux Could you provide more context? Do you use a generated form or Camunda Form? How can we reproduce the issue (from the start, not from Add a DateTime input)?

@nikku nikku added the needs more information Requires additional information to be actionable. label Aug 26, 2024
@bcazeaux
Copy link
Author

I'm using a Camunda Form created from the camunda modeler from a new file
image
image
image

@nikku nikku added Forms and removed needs more information Requires additional information to be actionable. labels Sep 12, 2024
@nikku
Copy link
Member

nikku commented Sep 16, 2024

Thanks. Pending clarifications internally. I forwarded this issue.

@vsgoulart
Copy link
Contributor

Hi @bcazeaux , thanks for reporting this

The property label is basically not used on anything and it's only there by a mistake because of a similar implementation with other component.

I created an issue on the form-js repos

@nikku I believe we can close the issue on this repo

@nikku
Copy link
Member

nikku commented Sep 17, 2024

@vsgoulart We'll leave the issue open and clearly link it to your upstream bug report.

@nikku nikku added the backlog Queued in backlog label Sep 17, 2024
@bcazeaux
Copy link
Author

And for my record, why using "dateLabel" instead of "label" like every other component ?

@vsgoulart
Copy link
Contributor

And for my record, why using "dateLabel" instead of "label" like every other component ?

@bcazeaux It's just an implementation detail of the the datetime component. Under the hood it's always the same component if we render the time input or not so it always uses dateLabel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working Forms
Projects
None yet
Development

No branches or pull requests

3 participants