Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-14808 Update the dell logo #14279

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented Sep 10, 2024

Done

  • Update the dell logo
    before
image

after
image

QA

  • on the main page, control + F and find "The professional developer’s preference"
  • Check the blue dell logo has been replaced with the white one

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-14808

@webteam-app
Copy link

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (6a88899) to head (a70bebc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14279      +/-   ##
==========================================
- Coverage   69.71%   69.63%   -0.09%     
==========================================
  Files         120      120              
  Lines        3418     3418              
  Branches     1174     1174              
==========================================
- Hits         2383     2380       -3     
- Misses       1011     1013       +2     
- Partials       24       25       +1     

see 1 file with indirect coverage changes

@minkyngkm minkyngkm merged commit 5201d40 into canonical:main Sep 11, 2024
15 of 16 checks passed
@minkyngkm minkyngkm deleted the WD-14808-update-dell-logo branch September 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants