Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents: mobile, other improvements #4777

Open
juanruitina opened this issue Jun 2, 2023 · 2 comments
Open

Table of contents: mobile, other improvements #4777

juanruitina opened this issue Jun 2, 2023 · 2 comments
Assignees
Labels
Review: Design needed Vanilla WG Task owned by Vanilla Working Group WG: Validated Validate working group proposals

Comments

@juanruitina
Copy link

juanruitina commented Jun 2, 2023

Pattern to amend

Table of contents

Context

The is some tweaks we could apply to the table of contents on mobile:

  • The table of contents looks rather misaligned due to x-padding.
  • When placed in a column on the right on desktop, it shows up after the main content on mobile, becoming unaccessible. We could place it above the content, but in some cases there might be many links. Should we consider another toggle for this? How would it play with the sidebar toggle?
  • Touch surface for links seems small.

Beyond mobile:

  • When a link label wraps, it looks like two different links. Some margin beyond line height could work.
  • In most cases, the heading should be a H2. When that's the case, it inherits weight 100, it really looks too thin. It wouldn't pass the APCA test (WIP).

Visual

How it is:

vanillaframework io_docs_examples_patterns_table-of-contents

Some initial style suggestions:

vanillaframework io_docs_examples_patterns_table-of-contents (1)

@juanruitina juanruitina added the WG: Proposal Working group proposals label Jun 2, 2023
@danielmutis
Copy link

WG:
@juanruitina and @danielmutis to look at how the mobile experience of this component could be improved.
Would also be good to identify if this component could be useful in any other situations.

Current designs for docs pages can be found here.

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15230.

This message was autogenerated

@bartaz bartaz added Vanilla WG Task owned by Vanilla Working Group and removed P3 Needs decision Needs team agreement in terms of triaging. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: Design needed Vanilla WG Task owned by Vanilla Working Group WG: Validated Validate working group proposals
Projects
None yet
Development

No branches or pull requests

3 participants