Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libbiosig on Windows #47

Open
cbrnr opened this issue Mar 7, 2017 · 7 comments
Open

Build libbiosig on Windows #47

cbrnr opened this issue Mar 7, 2017 · 7 comments

Comments

@cbrnr
Copy link
Owner

cbrnr commented Mar 7, 2017

Currently we can build libbiosig from source only on macOS and Linux. However, we should try to get it to work on Windows as well using our build environment. Right now, this means MinGW, this should be our priority here. Since SigViewer builds with VC without any problem, in theory it should be possible to compile libbiosig with VC as well. This would be the ideal solution, because VC is the default build environment on Windows, but I doubt that it will be easy to adapt the source of libbiosig (it uses a lot of GCC extensions).

@Yida-Lin
Copy link
Contributor

Yida-Lin commented Mar 7, 2017

@cbrnr In my impression SigViewer never worked with VC on Windows? Got a ton of mistakes always. Same with libbiosig. I had multiple tries last year on both but never succeeded.

@cbrnr
Copy link
Owner Author

cbrnr commented Mar 7, 2017

No, SigViewer does build with VC if you remove all biosig-related stuff.

@cbrnr
Copy link
Owner Author

cbrnr commented Mar 7, 2017

Note that you need to have the VS version of Qt installed and not the MinGW one.

@tstenner
Copy link

No, SigViewer does build with VC if you remove all biosig-related stuff.

Is there a branch with a bunch of #ifdefs?

@cbrnr
Copy link
Owner Author

cbrnr commented Dec 13, 2019

No, unfortunately we never bothered to do that. I don't have the time to look into that, but I think everything should work with MinGW64, which is now officially supported by Qt.

@tstenner
Copy link

I have a semi-official all-in-one installer for lsl and so far an xdf file visualization tool is missing.
Everything's built with Visual Studio, so if it were possible to include a minimal sigviewer that'd be great.

@cbrnr
Copy link
Owner Author

cbrnr commented Dec 18, 2019

Removing Biosig won't be easy. I'm not happy how deeply it became integrated at some point, but I don't have the time to work on that. Changing Biosig to be compatible with VSC won't be easy either, and I don't have time for that either. If someone wants to work on that I'd be more than happy, but I doubt this is going to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants