Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport SQS queue_delete() method doesn't actually delete the queue #2091

Closed
ivanprjcts opened this issue Aug 5, 2024 · 2 comments
Closed

Comments

@ivanprjcts
Copy link
Contributor

I wonder why .queue_delete() method of SQS channel is not actually deleting the queue. I haven't found any doc or comment related to it. I'm sure there is a good reason for it.

The method ._delete() of SQS Channel class.

    def _delete(self, queue, *args, **kwargs):
        """Delete queue by name."""
        if self.predefined_queues:
            return
        super()._delete(queue)
        self._queue_cache.pop(queue, None)

SQS queues may be deleted using boto3 .delete_queue()(https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs/client/delete_queue.html).

It would be great to have some docs/comment about it.

Thank you :)

@thedrow
Copy link
Member

thedrow commented Aug 14, 2024

This is a bug in my opinion. We'd welcome a PR to fix this issue.

@Nusnus
Copy link
Member

Nusnus commented Aug 18, 2024

This is a bug in my opinion. We'd welcome a PR to fix this issue.

Please add me for review for such a PR, thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants